-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokens for Invites and Email confirmatin #544
Comments
joepio
added a commit
that referenced
this issue
Dec 2, 2022
joepio
added a commit
that referenced
this issue
Dec 16, 2022
joepio
added a commit
that referenced
this issue
Jan 23, 2023
joepio
added a commit
that referenced
this issue
Jan 24, 2023
joepio
added a commit
that referenced
this issue
Feb 5, 2023
joepio
added a commit
that referenced
this issue
Feb 25, 2023
joepio
added a commit
that referenced
this issue
Feb 28, 2023
joepio
added a commit
that referenced
this issue
Mar 11, 2023
joepio
added a commit
that referenced
this issue
Mar 30, 2023
joepio
added a commit
that referenced
this issue
Jul 31, 2023
joepio
added a commit
that referenced
this issue
Jul 31, 2023
joepio
added a commit
that referenced
this issue
Jul 23, 2024
joepio
added a commit
that referenced
this issue
Jul 23, 2024
joepio
added a commit
that referenced
this issue
Jul 23, 2024
joepio
added a commit
that referenced
this issue
Jul 23, 2024
joepio
added a commit
that referenced
this issue
Oct 7, 2024
joepio
added a commit
that referenced
this issue
Oct 7, 2024
joepio
added a commit
that referenced
this issue
Feb 3, 2025
joepio
added a commit
that referenced
this issue
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some systems that I'm working on / have worked on where tokens are needed:
All these have some things in common:
read
rights are limited to the creator, or nonexistent.But there are also some differences:
Other thoughts and considerations:
Invites
plugin that handles all commits done toInvite
instances.Approaches
Add some token helper functions in
atomic-lib
If we continue to use Class Extender Plugins, we should make sure that most logic is shared. That means:
Add a
token
property with custom property levelAdd a single
/token
endpointProtected properties
We can add an
isProtected
attribute toProperty
definitions. When this is set to true, we prevent users from editing this field. That way, we can know that nobody can create malicious invites, for example.Signed tokens (e.g. JWTs)
Most of the current designs are stateful. They require that the server stores something and later retrieves this. This brings complexity - we need to store tokens, retrieve them, make sure they are unique, etc... Instead, we could let the server create signed tokens which contain all relevant information.
@id
fields are probably empty, as they are not hosted anywheresled::Tree
.In the case of an email reset, the JWT would contain the e-mail address and the Agent URL.
For pubkey reset, only the Agent URL.
Invites are another story... I'm not sure if the JWT approach works there.
Invites can be used multiple times.
A counter has to be decremented when they are used.
Crates:
The text was updated successfully, but these errors were encountered: