-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sudomain support, register endpoint #505
Draft
joepio
wants to merge
45
commits into
develop
Choose a base branch
from
#502-wildcard-subdomain
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9fca9c3
to
3b55040
Compare
d92d8d8
to
459c575
Compare
459c575
to
a4121ac
Compare
bbc2bab
to
ed749d6
Compare
b391820
to
3951526
Compare
6c322c8
to
2087d64
Compare
8151baf
to
c9b8a0b
Compare
f300aff
to
4e50e2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 66.12% 64.35% -1.77%
==========================================
Files 73 79 +6
Lines 8200 8597 +397
==========================================
+ Hits 5422 5533 +111
- Misses 2778 3064 +286
|
32856aa
to
93ab91e
Compare
93ab91e
to
56fdb2d
Compare
56fdb2d
to
bfac36a
Compare
bfac36a
to
7dac7b6
Compare
14 tasks
7dac7b6
to
d7d6495
Compare
d7d6495
to
0ef208d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
.full_uri()
method instead of some hacky reconstruction. Will be added in 4.8 probably?//
in search results (and other places?)format!(
occurences where we combine things to create a URL, replace withURL::join
.all_resources
check forinclude_external
. Currently does not properly use subdomains.new drive
behavior/resetPubkey
type of endpoint, in case you lose your private keyPR Checklist: