-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain new URLs #556
Comments
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At this moment, Atomic Server is very liberal in accepting Commits that create new resources. This can lead to weird situations, that should be prevented:
john
using themary.com/hi
URL, not allowingmary
to edit it)example.com/welcome
even if you only should accessexample.com/shared/1259015
This should definitely not be allowed.
How can we deal with this?
Check for
append
right in pathUser creates
example.com/topics/1/test/2
, we check the resourcesexample.com
,example.com/topics
,example.com/topics/1
andexample.com/topics/1/test
. If the user has anappend
right on any of these resources, we allow minting the URL. If not, the user cannot create the resource.Check if the
parent
is in the path of the new URLUser creates
example.com/topics/1/test/2
, we need to check that the parent of that resource is part of that URL, such asexample.com
orexample.com/topics/1
.If that parent matches, we can simply perform the regular check at the parent.
This would be a far more severe limitation, but would help to keep things organised and predictable.
example.com/topics/1
may not exist, even if/topics/1/test
does exist. This can be confusing.atomicdata.dev.example.com
with the parent set toatomicdata.dev
/endpoint
resources? Should we nest these, too? Might be a good idea, but has quite a bit of impact.local-id
s that do not adhere to this nesting. How do we deal with these? => Throw an error, the JSON-AD creator should consider the parent-child constraints./home
and make that one public.Check if the origin of the URL is the same as the primary parent
The text was updated successfully, but these errors were encountered: