Remove custom CLI flags in child worker before requiring test file

[sindresorhus]

We shouldn't expose custom CLI flags to the test file. It might change the behavior of user's code.

Currently we expose --color in the test file, even though the user just ran $ ava with no flag.

I had to implement a workaround for now: https://github.com/sindresorhus/xo-init/blob/9755f41134d0c8199674c1888d88cca3375358a3/test.js#L8

@novemberborn Thoughts?

[novemberborn]

IIRC I wasn't a fan of passing --color, but you said it was convention ;-)

We also pass a JSON string as argv[2] though. I'm not sure process.argv should be relied upon inside tests.

[sindresorhus]

IIRC I wasn't a fan of passing --color, but you said it was convention ;-)

I know. It is convention though, but turns out to be annoying in this context.

I'm not sure process.argv should be relied upon inside tests.

Oh it shouldn't, but I don't think we should clutter it either.

---

How about we pass whether to use colors or not in the argv[2] JSON string and handle it accordingly before requiring the test file?

[novemberborn]

If you mean that for use cases under our control we use options.color, yes. It could be argued though that if the user explicitly passes --color and --no-color flags, due to the convention, we should still forward those.

[sindresorhus]

If you mean that for use cases under our control we use options.color, yes.

Yes, I mean our auto-detection.

It could be argued though that if the user explicitly passes --color and --no-color flags, due to the convention, we should still forward those.

Agreed.

[kevva]

So from what I could gather from #1198, we pass on --color/--no-color to the worker to enable/disable for example chalk.red('unicorn') in the test files. If we skip it and passes on whatever flags the user passes on, chalk will be disabled in the test files (because it's not a TTY) unless the user explicitly runs ava with --color.

So, do we want colored text in test files to always display as colored?

[sindresorhus]

@kevva Yeah, basically, we want to pass on the auto-detect color support to the child worker, which always detects it as no color support, without clobbering process.argv for the test file context.

[novemberborn]

Yeah, basically, we want to pass on the auto-detect color support to the child worker, which always detects it as no color support

To clarify, the worker will never detect color support itself, hence us needing to forward the detected support from the main process.

(It read as ambiguous to me.)

[kevva]

Yeah, basically, we want to pass on the auto-detect color support to the child worker, which always detects it as no color support, without clobbering process.argv for the test file context.

We already do that, I think. The only function --color/--no-color currently fills is passing the auto detection into the actual tests (not the reporter) which I don't think we should do. If the user wants to log stuff in their tests using chalk, just run ava with the --color flag.