Allow worker CLI flags to be specified #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing the options passed to the worker isn't great. These tests don't seem terribly useful either, though I haven't confirmed whether they're replicating other tests. That said they don't cover explicit logic either.
This removes AVA's internal flags, set by fork.js and consumed by test-worker.js. Fixes #1393. AVA now forwards arguments, provided after an `--` argument terminator, to the worker process. Arguments are available from `process.argv[2]` onwards.
This was referenced Feb 12, 2018
sindresorhus
approved these changes
Feb 13, 2018
|
Yay! I've wanted this many times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes AVA's internal flags, set by
fork.jsand consumed bytest-worker.js. Fixes #1393.AVA now forwards arguments, provided after an
--argument terminator, to the worker process. Arguments are available fromprocess.argv[2]onwards.I've also removed some
pkg-conftests. These were accessing the options passed to the worker, which isn't great. They didn't seem terribly useful either, though I haven't confirmed whether they're replicating other tests. That said they don't cover explicit logic either.