Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: aws ecr get-login-password #4867

Closed
rpnguyen opened this issue Jan 22, 2020 · 0 comments · Fixed by #4874
Closed

Proposal: aws ecr get-login-password #4867

rpnguyen opened this issue Jan 22, 2020 · 0 comments · Fixed by #4874
Labels
feature-request A feature should be added or improved.

Comments

@rpnguyen
Copy link
Contributor

This is a proposal for a new AWS CLI command for ECR

$ aws ecr get-login-password
cGFzc3dvcmQ=

This command can be used in the following ways:

$ aws ecr get-login-password | docker login --username AWS --password-stdin 111111111111.dkr.ecr.us-west-2.amazonaws.com
Login Succeeded

$ docker login --username AWS --password "$(aws ecr get-login-password)" 111111111111.dkr.ecr.us-west-2.amazonaws.com
Login Succeeded

This idea has been previously proposed by @theY4Kman #2875 (comment) and @kojiromike #3687 (comment)
@rpnguyen rpnguyen mentioned this issue Jan 23, 2020
Closed
@joguSD joguSD added the feature-request A feature should be added or improved. label Jan 23, 2020
matthew-russo pushed a commit to matthew-russo/aws-cli that referenced this issue Jan 24, 2020
adds aws ecr get-login-password customization
a9bbbc0 
as proposed in aws#4867,
and previously discussed in
aws#2875 (comment)
aws#3687 (comment)

this commit adds a new customization command for ECR that only
returns the password to login to a registry. this approach is
composable, is compatible with other container clients, allows
use of functionality like Docker's --password-stdin flag, and
is more resilient to changes in client APIs
matthew-russo pushed a commit to matthew-russo/aws-cli that referenced this issue Jan 24, 2020
adds aws ecr get-login-password customization
1261783 
as proposed in aws#4867,
and previously discussed in
aws#2875 (comment)
aws#3687 (comment)

this commit adds a new customization command for ECR that only
returns the password to login to a registry. this approach is
composable, is compatible with other container clients, allows
use of functionality like Docker's --password-stdin flag, and
is more resilient to changes in client APIs
matthew-russo pushed a commit to matthew-russo/aws-cli that referenced this issue Jan 24, 2020
adds aws ecr get-login-password customization
8969480 
as proposed in aws#4867,
and previously discussed in
aws#2875 (comment)
aws#3687 (comment)

this commit adds a new customization command for ECR that only
returns the password to login to a registry. this approach is
composable, is compatible with other container clients, allows
use of functionality like Docker's --password-stdin flag, and
is more resilient to changes in client APIs
@matthew-russo matthew-russo mentioned this issue Jan 24, 2020
Merged
matthew-russo pushed a commit to matthew-russo/aws-cli that referenced this issue Jan 24, 2020
adds aws ecr get-login-password customization
784906d 
as proposed in aws#4867,
and previously discussed in
aws#2875 (comment)
aws#3687 (comment)

this commit adds a new customization command for ECR that only
returns the password to login to a registry. this approach is
composable, is compatible with other container clients, allows
use of functionality like Docker's --password-stdin flag, and
is more resilient to changes in client APIs
matthew-russo pushed a commit to matthew-russo/aws-cli that referenced this issue Jan 24, 2020
adds aws ecr get-login-password customization
00cfc2c 
as proposed in aws#4867,
and previously discussed in
aws#2875 (comment)
aws#3687 (comment)

this commit adds a new customization command for ECR that only
returns the password to login to a registry. this approach is
composable, is compatible with other container clients, allows
use of functionality like Docker's --password-stdin flag, and
is more resilient to changes in client APIs
This was referenced Mar 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds aws ecr get-login-password customization matthew-russo/aws-cli
2 participants
@rpnguyen @joguSD