CHANGELOG: 1.17.10 mentions new 'aws ecr get-login-password' #5026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2.0.0 changelog entry includes:
... however the new
get-login-password
isn't mentioned anywhere in CHANGELOG.rst.The
get-login-password
command was introduced in #4874 in commit 00cfc2c which merged in d1f7339 and was first tagged in 1.17.10:This pull request updates the 1.17.10 changelog entry to mention this added
get-login-password
command.This is important because awscli v2 completely drops the previous
get-login
command, and many downstream consumers/maintainers will be trying to understand the window of cross-compatibility where awscli supported both commands.(Unfortunately,
get-login-password
only landed in 1.17.0 on 2020-02-05, andget-login
was dropped as of v2.0.0 on 2020-02-11, so there's only six version-days of cross-compatibility. I understand the v2 release represents breaking changes and v1 is still being maintained for now, but it still puts dependent tooling like https://github.com/buildkite-plugins/ecr-buildkite-plugin in an awkward position of trying to detect and support both.)Related context:
get-login-password
proposed in Proposal: aws ecr get-login-password #4867get-login-password
implemented in addsaws ecr get-login-password
customization #4874get-login
removed in [v2] Remove ecr get-login command #4886By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.