Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: 1.17.10 mentions new 'aws ecr get-login-password' #5026

Merged
merged 2 commits into from
Mar 13, 2020
Merged

CHANGELOG: 1.17.10 mentions new 'aws ecr get-login-password' #5026

merged 2 commits into from
Mar 13, 2020

Conversation

pda
Copy link
Contributor

@pda pda commented Mar 3, 2020

The v2.0.0 changelog entry includes:

Removed support for the ecr get-login command in favor of ecr get-login-password

... however the new get-login-password isn't mentioned anywhere in CHANGELOG.rst.

The get-login-password command was introduced in #4874 in commit 00cfc2c which merged in d1f7339 and was first tagged in 1.17.10:

$ git tag --contains 00cfc2cb | sort --version-sort | head -n1
1.17.10

This pull request updates the 1.17.10 changelog entry to mention this added get-login-password command.

This is important because awscli v2 completely drops the previous get-login command, and many downstream consumers/maintainers will be trying to understand the window of cross-compatibility where awscli supported both commands.

(Unfortunately, get-login-password only landed in 1.17.0 on 2020-02-05, and get-login was dropped as of v2.0.0 on 2020-02-11, so there's only six version-days of cross-compatibility. I understand the v2 release represents breaking changes and v1 is still being maintained for now, but it still puts dependent tooling like https://github.com/buildkite-plugins/ecr-buildkite-plugin in an awkward position of trying to detect and support both.)

Related context:


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #5026 into develop will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5026      +/-   ##
===========================================
- Coverage    93.95%   93.71%   -0.25%     
===========================================
  Files          188      188              
  Lines        14525    14525              
===========================================
- Hits         13647    13612      -35     
- Misses         878      913      +35
Impacted Files Coverage Δ
awscli/compat.py 53.07% <0%> (-9.24%) ⬇️
awscli/customizations/history/db.py 91.44% <0%> (-6.58%) ⬇️
awscli/argparser.py 92.47% <0%> (-2.16%) ⬇️
awscli/testutils.py 64.6% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a388c12...ee23ebf. Read the comment docs.

This ensures that the entry will be retained when the changelog
is regenerated.
@kyleknap
Copy link
Contributor

Thanks for the pull request. I added an additional commit on top so that we include it in our JSON file for that version. This is important because we regenerate the CHANGELOG from these files so it would have been wiped away on the next regeneration. Thanks again!

@kyleknap kyleknap merged commit 65ef205 into aws:develop Mar 13, 2020
@pda pda deleted the changelog-1-17-10-ecr-get-login-password branch February 23, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants