Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the facades? #1

Closed
danielboendergaard opened this issue Mar 31, 2013 · 1 comment
Closed

Extend the facades? #1

danielboendergaard opened this issue Mar 31, 2013 · 1 comment

Comments

@danielboendergaard
Copy link
Contributor

A lot of methods is defined in the facades (Route::is() etc), if you extend them you will get autocomplete on those as well. As far as I can see, there's no downside to it, but maybe I've missed something.

If you think it's a good idea, just change this line https://github.com/barryvdh/laravel-ide-helper/blob/master/src/Barryvdh/LaravelIdeHelper/GeneratorCommand.php#L137 to $output .= " class $alias extends $facade{\n";

barryvdh added a commit that referenced this issue Apr 1, 2013
Fixes Issue #1
Only extended when it is not the same as the root class (because of
overriding static methods)
@barryvdh
Copy link
Owner

barryvdh commented Apr 1, 2013

Yes, I had to change a few things to prevent errors for making methods static when extending, but this seems to work fine indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants