Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flysystem\Local error back on Lumen 8 #1105

Closed
ghost opened this issue Dec 2, 2020 · 6 comments
Closed

Flysystem\Local error back on Lumen 8 #1105

ghost opened this issue Dec 2, 2020 · 6 comments
Labels
bug lumen

Comments

@ghost
Copy link

ghost commented Dec 2, 2020 •
edited by ghost
Loading

Versions:

  • ide-helper Version: 2.8.x-dev
  • Lumen Version: 8.2.1
  • PHP Version: 7.4.4

Description:

Generate fails due to a dependency on League\Flysystem\Local. league/flysystem is installed but the class doesn't seem to exist.

Steps To Reproduce:

php artisan ide-helper:generate

Error shown:


In FilesystemManager.php line 164:
                                                    
  Class 'League\Flysystem\Adapter\Local' not found
@ghost ghost added the bug label Dec 2, 2020
@Uplink03
Copy link

Uplink03 commented Dec 3, 2020

Looks like league/flysystem 2.0 changed its structure, so now this is in here:

  • File: vendor/league/flysystem/src/Local/LocalFilesystemAdapter.php
  • Class path: League\Flysystem\Local\LocalFilesystemAdapter

Version 1.x is the one that fixes this error: composer require --dev league/flysystem=^1.1 but exhibits bug #1042 instead

@Uplink03
Copy link

Uplink03 commented Dec 3, 2020 •
edited
Loading

The workaround I have now is:

  1. composer require --dev league/flysystem=^1.1

  2. Edit vendor/barryvdh/laravel-ide-helper/src/IdeHelperServiceProvider.php

    Remove or comment out this code (search for Application, lines 119-121 in mine):

            if ((int) Application::VERSION < 8) {
            return new PhpEngine();
        }

Of course, this doesn't help that much if you want to commit everything in git and have it work later.

@araeuchle
Copy link

@Uplink03 solution worked for me :) thanks :)

@mfn mfn added the lumen label Apr 18, 2021
@kamleshwebtech
Copy link

I am using Lumen 8.0 version, What is solution of this problem, please share. Thanks.

@Shikachuu
Copy link

Shikachuu commented May 6, 2021 •
edited
Loading

@kamleshwebtech

I am using Lumen 8.0 version, What is solution of this problem, please share. Thanks.

The following command, as @Uplink03 commented:
composer require --dev league/flysystem=^1.1

Thanks again, @Uplink03!

hiroki-it added a commit to hiroki-it/microservices-backend that referenced this issue Feb 6, 2022
@hiroki-it
update league/flysystemをインストールした．
9fc4055 
barryvdh/laravel-ide-helper#1105 (comment)
mfn added a commit to mfn/laravel-ide-helper that referenced this issue Feb 19, 2023
@mfn
Remove offical support for Lumen
c9d2856 
I'm proposing to drop official suport for Lumen for the following reasons:
- Lumen itself is dead, per [1]
  > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com).

  Laravel Octact is just Laravel and no one using ide-helper with it
  needs anything special.
- For now, the change is mostly on the logistics side (readme, run tests,
  issues). In the past we had some special code but over time this was
  already removed.
  For now people still can use it and nothing will break out of the blue,
  but eventually it might

There are a only a few Lumen related issues open currently which would
be closed by this (barryvdh#1105, barryvdh#1069, barryvdh#438).

[1] laravel/lumen@69b2657
@mfn mfn mentioned this issue Feb 19, 2023
Merged
9 tasks
mfn added a commit to mfn/laravel-ide-helper that referenced this issue Feb 19, 2023
@mfn
Remove offical support for Lumen
1af813b 
I'm proposing to drop official suport for Lumen for the following reasons:
- Lumen itself is dead, per [1]
  > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com).

  Laravel Octact is just Laravel and no one using ide-helper with it
  needs anything special.
- For now, the change is mostly on the logistics side (readme, run tests,
  issues). In the past we had some special code but over time this was
  already removed.
  For now people still can use it and nothing will break out of the blue,
  but eventually it might

There are a only a few Lumen related issues open currently which would
be closed by this (barryvdh#1105, barryvdh#1069, barryvdh#438).

[1] laravel/lumen@69b2657
barryvdh added a commit that referenced this issue Feb 20, 2023
@mfn @barryvdh
Remove offical support for Lumen (#1425)
4dc20b0 
I'm proposing to drop official suport for Lumen for the following reasons:
- Lumen itself is dead, per [1]
  > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com).

  Laravel Octact is just Laravel and no one using ide-helper with it
  needs anything special.
- For now, the change is mostly on the logistics side (readme, run tests,
  issues). In the past we had some special code but over time this was
  already removed.
  For now people still can use it and nothing will break out of the blue,
  but eventually it might

There are a only a few Lumen related issues open currently which would
be closed by this (#1105, #1069, #438).

[1] laravel/lumen@69b2657

Co-authored-by: Barry vd. Heuvel <[email protected]>
@mfn
Copy link
Collaborator

mfn commented Feb 20, 2023

Hey 👋🏼 whilst integration in Lumen might still work, due to decline in usage of Lumen and better alternatives like Laravel Octane, Lumen is not officially supported anymore (the state of affairs where never really great, to begin with)

@mfn mfn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this issue Feb 16, 2024
@mfn @barryvdh @d3v2a
Remove offical support for Lumen (barryvdh#1425)
b84bee8 
I'm proposing to drop official suport for Lumen for the following reasons:
- Lumen itself is dead, per [1]
  > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com).

  Laravel Octact is just Laravel and no one using ide-helper with it
  needs anything special.
- For now, the change is mostly on the logistics side (readme, run tests,
  issues). In the past we had some special code but over time this was
  already removed.
  For now people still can use it and nothing will break out of the blue,
  but eventually it might

There are a only a few Lumen related issues open currently which would
be closed by this (barryvdh#1105, barryvdh#1069, barryvdh#438).

[1] laravel/lumen@69b2657

Co-authored-by: Barry vd. Heuvel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug lumen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mfn @Uplink03 @araeuchle @Shikachuu @kamleshwebtech