Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate error when macroable class has a "fake" method #1066

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Fix generate error when macroable class has a "fake" method #1066

merged 1 commit into from
Sep 21, 2020

Conversation

domkrm
Copy link
Contributor

@domkrm domkrm commented Sep 21, 2020

This should fix the issue #1065

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me 👍

@domkrm can you add a changelog entry under "Fixed"? 🙏

@domkrm
Copy link
Contributor Author

domkrm commented Sep 21, 2020

I have added the changelog entry.

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domkrm thanks, also for the quick fix 🙇

@barryvdh IMHO good to merge!

@barryvdh barryvdh merged commit 0168e72 into barryvdh:master Sep 21, 2020
@lloricode
Copy link

Hi, are we able to use this with release tag?

@mfn
Copy link
Collaborator

mfn commented Sep 29, 2020

Unfortunately not yet, the last release was a while ago => https://github.com/barryvdh/laravel-ide-helper/releases/tag/v2.8.1

You can try if using 2.8-dev works for you in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants