Skip post_migrate when running tests #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Mar 22, 2021
| @@ -35,7 +34,7 @@ class IdeHelperServiceProvider extends ServiceProvider implements DeferrableProv | |||
| */ | |||
| public function boot() | |||
| { | |||
| if ($this->app['config']->get('ide-helper.post_migrate', [])) { | |||
| if (!$this->app->runningUnitTests() && $this->app['config']->get('ide-helper.post_migrate', [])) { | |||
There was a problem hiding this comment.
It should: https://github.com/laravel/lumen-framework/blob/8.x/src/Application.php#L896
Edit: Lumen integration test passes so it does
There was a problem hiding this comment.
Thank you, LGTM!
Could you please resolve the merge conflicts? Don't see any blockerS!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips post migrate hooks when application is running unit tests. This should not cause any problems but it's unnecessary to generate the helpers hundred times. Also test should not have a sideeffect.
Type of change
Checklist
composer fix-style