Fixing issue where incorrect autoloader unregistered (#1069) #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
approved these changes
Apr 9, 2021
tezhm
force-pushed
the
bug-1069
branch
2 times, most recently
from
26ff808 to
0fddf3f
Compare
|
Added change log entry. Would it be possible to cherry pick this commit and add a v2.8.3 release? Got some dependency conflicts with v2.9.x. All good if too much hassle, got a branch in fork which I can use. |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Terence Marks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix for #1069.
Unregisters the autoloader registered via
MetaCommand->registerClassAutoloadExceptionsby reference instead of assuming it is the last registered autoloader.I'm marking this as a "breaking change" because the
MetaCommand->registerClassAutoloadExceptionsis protected and I've changed the return type from void to callable (which is the registered autoloader). If you'd prefer, can solve without modifying method definition.Type of change
Checklist
composer fix-style