Support variadic parameters in models command #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaffe-fr
force-pushed
the
patch-1
branch
4 times, most recently
from
d0bed24 to
c0de872
Compare
Messhias
approved these changes
Jul 23, 2021
|
This looks good, but would it be possible to add a test to cover this? |
|
Hi @barryvdh, |
|
Probably easiest to copy an existing test and just change a parameter to variadic. |
|
I added some tests @barryvdh. Is it ok? |
barryvdh
approved these changes
Aug 4, 2021
|
Thanks! 👍 |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support of variadic paremeters in ModelsCommand.
Type of change
New feature
Checklist
composer fix-style@mfn Where should I add some tests?
Thanks