Add support for CastsInboundAttributes #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sforward
force-pushed
the
fix/inbound-attribute-cast
branch
from
7d6df5b to
50b3c55
Compare
sforward
force-pushed
the
fix/inbound-attribute-cast
branch
from
50b3c55 to
cd15a3c
Compare
sforward
force-pushed
the
fix/inbound-attribute-cast
branch
from
cd15a3c to
dcc7bb2
Compare
|
Sure, I have rebased the code again. I'm willing to help testing PR's if that's the current bottleneck of this repo. |
I think this is always welcome, I'm definitely not vetting PRs enough whose features I don't know well / not use. Ultimate it's up to @barryvdh for merging and I try to assist where time permits. Technically I've the ability to merge stuff, but we've a social agreement that he's the decision maker. For this particular PR, I've no doubts about the technical part and my approval+merge still stands 😄 |
ppmathis
pushed a commit
to ppmathis/laravel-ide-helper
that referenced
this pull request
Nov 12, 2022
* Add support for CastsInboundAttributes * Update changelog Co-authored-by: Simon Verwaard <[email protected]>
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Add support for CastsInboundAttributes * Update changelog Co-authored-by: Simon Verwaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for custom cast classes that implement the CastsInboundAttributes interface ( https://laravel.com/docs/9.x/eloquent-mutators#inbound-casting). Currently the Cast class will incorrectly end up as return value of the attribute.
Type of change
Checklist
composer fix-style