Fix return type of methods provided by SoftDeletes
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense I think, not sure why originally it was |
barryvdh
approved these changes
Aug 11, 2022
ppmathis
pushed a commit
to ppmathis/laravel-ide-helper
that referenced
this pull request
Nov 12, 2022
* Fix return type of methods provided by `SoftDeletes` * Update CHANGELOG * fix test / update snapshot
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Fix return type of methods provided by `SoftDeletes` * Update CHANGELOG * fix test / update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix return type of methods provided by
SoftDeletes.Detail
The
SoftDeletesmodel has three methods available:As the linked code shows, they return
\Illuminate\Database\Eloquent\Builder, but theide-helper:modelscommand generates the annotation\Illuminate\Database\Query\Builder. I fixed this difference.Notice
Previously there were no issues, but with the fix for Laravel v9.3.0 , some static analysis tools such as PHPStan now report errors in the traditional ide-helper process.
Type of change
Checklist
composer fix-style