Fix model factory method arguments for Laravel >= 9 #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimski
force-pushed
the
fix/model-factory-method-9.x
branch
from
e29e7e1 to
66f487f
Compare
barryvdh
approved these changes
Aug 11, 2022
ppmathis
pushed a commit
to ppmathis/laravel-ide-helper
that referenced
this pull request
Nov 12, 2022
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The arguments for
HasFactory::factoryhave changed since Laravel 9, so the docblocks have to be changed accordingly.laravel/framework@0f0f883
In order to test this change, you will need Laravel 9, which will not install because of conflicting/limiting dependencies. I tested it by changing the following dependencies:
friendsofphp/php-cs-fixerfrom^2to^2 || ^3vimeo/psalmfrom^3.12to^3.12 || ^4Updating these packages will open such a can of worms, that I didn't include these updates in this PR.
Type of change
Checklist
composer fix-styleCode style fixing cannot be done with PHP 8.1. Another reason
friendsofphp/php-cs-fixershould be updated to^3.