Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for AsCollection and AsArrayObject casts #1393

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

pataar
Copy link
Contributor

@pataar pataar commented Nov 17, 2022

Summary

This adds support for the AsCollection and AsArrayObject casts. Both of these are referenced in the Laravel documentation.

This only works for Laravel > 8.28.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh closed this Feb 8, 2024
@barryvdh barryvdh reopened this Feb 8, 2024
@barryvdh
Copy link
Owner

barryvdh commented Feb 8, 2024

Hmm tests seem to be failing

@pataar
Copy link
Contributor Author

pataar commented Feb 8, 2024

@barryvdh Fixed!

@barryvdh
Copy link
Owner

barryvdh commented Feb 8, 2024

Oh oops, that was the CS Fixers fault

@barryvdh barryvdh merged commit 341c0ab into barryvdh:master Feb 8, 2024
33 checks passed
@pataar
Copy link
Contributor Author

pataar commented Feb 8, 2024

Thanks for the merge! I think #1423 can be closed now

d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
…1393)

* feat: add support for AsCollection and AsArrayObject casts

* update changelog

* improve tests

* remove change

* composer fix-style

* snapshot

---------

Co-authored-by: Barry vd. Heuvel <[email protected]>
Co-authored-by: laravel-ide-helper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants