Add AllowDynamicProperties Attribute to cooperate with php8.2 deprecation

[GeoSot]

Summary

Trying to Add #[\AllowDynamicProperties] before class on mixin, as solution to PHPStan errors

Note: could add an extra check PHP_VERSION_ID>= 80200, but seems redundant as attributes have backwards compatibility

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

• Existing tests have been adapted and/or new tests have been added
• Add a CHANGELOG.md entry
• Update the README.md
• Code style has been fixed via composer fix-style

rel #1386
closes #1402

[GeoSot]

@barryvdh

Any news on this? It has started to be much problematic with phpstan support

[Orrison]

@barryvdh any possibility of this merging in any time soon? Looks like it has been approved and tests are passing. Is currently needed to make use of mixins while using PHP8.2

[mfn]

I want to understand the issue better first, I added a comment in #1402 (comment)

[GeoSot]

I want to understand the issue better first, I added a comment in #1402 (comment)

@mfn please can you provide a solution here?

yes, generated class can extend the initial eloquent model, but either way is a 'stub'. So 'AllowDynamicProperties' can just do this without extra complexity.
We would like any of both solutions, just to help us go on with php 8.2

[barryvdh]

Is this still required now that the files are ignored?

[GeoSot]

php 8.2 introduced a change where dynamicProperties are not allowed be default, so when phpStan reads the _ide_helper*.php files, in order to resolve the laravel "magic" properties form docblocks, throws the exception Access to an undefined property (details)

Short answer: Yes we really need this , and would appreciate your help

[barryvdh]

This PR should disable the inspection though right? #1486

[GeoSot]

Yes for codesniffer, and for phpstorm. PhpStan doesn't seem to respect/recognize any the following

/* @noinspection ALL */
// @formatter:off
// phpcs:ignoreFile

ps: have already test it, getting the dev-master on composer

[barryvdh]

See #1516
Should we revert this for now?

[mfn]

Maybe my hunch for the proposed fix is correct, then it would be as fast as the revert. But I can't do it right now

[barryvdh]

See #1517