Support the BINARY(...) database field type #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In singlestore we define some strings as
$table->char($columnName, 40)->charset('binary')->collation('binary');
In singelstore, this becomes 'BINARY(40)' instead of 'CHAR(40) CHARACTER SET 'binary' COLLATE 'binary'
This change would allow the generated proeperties to be 'string' instead of 'mixed', as using a string is correct in this case.
barryvdh
approved these changes
Feb 7, 2024
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
In singlestore we define some strings as
$table->char($columnName, 40)->charset('binary')->collation('binary');
In singelstore, this becomes 'BINARY(40)' instead of 'CHAR(40) CHARACTER SET 'binary' COLLATE 'binary'
This change would allow the generated proeperties to be 'string' instead of 'mixed', as using a string is correct in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In singlestore we define some strings as
$table->char($columnName, 40)->charset('binary')->collation('binary');
In singelstore, this becomes 'BINARY(40)' instead of 'CHAR(40) CHARACTER SET 'binary' COLLATE 'binary'
This change would allow the generated proeperties to be 'string' instead of 'mixed', as using a string is correct in this case.
Summary
Type of change
Checklist
composer fix-style