Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept scope & scopes as relation #1452

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Accept scope & scopes as relation #1452

merged 1 commit into from
Feb 8, 2024

Conversation

Muetze42
Copy link
Contributor

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Relations were not included in the PHPDoc block if they were named scope or scopes.

image

barryvdh
barryvdh requested changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@barryvdh barryvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this could use a test though. Could you maybe add one?

@barryvdh barryvdh merged commit 4751420 into barryvdh:master Feb 8, 2024
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
@Muetze42 @d3v2a
Accept scope & scopes as relation (barryvdh#1452)
17751ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryvdh barryvdh barryvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muetze42 @barryvdh