Fix unsetMethod in ModelsCommand #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo108
force-pushed
the
patch-1
branch
2 times, most recently
from
04032ba to
22fddc9
Compare
|
@barryvdh any chance to check this PR? thanks. |
|
Maybe we should lowercase the check instead also? |
|
@barryvdh You're right since methods are case-insensitive in PHP. Please check the updated code. |
|
@barryvdh Please check when you have time, thanks. |
|
@barryvdh bump |
|
@barryvdh Sorry to bother you again, but I'm really hope this PR can be merged, please let me know what your concern, thanks! |
barryvdh
approved these changes
Feb 7, 2024
|
Hmm not really sure why this is failing |
|
ah probably unrelated, let me try again. |
|
All good! Thanks for your patience |
|
Thanks! it would be nice if you could release a new version. |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Fix unsetMethod in ModelsCommand * composer fix-style --------- Co-authored-by: Barry vd. Heuvel <[email protected]> Co-authored-by: laravel-ide-helper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The key of
ModelsCommand::$methodsis case sensitive, so we should not convert the$nameto lowercase when unset.Type of change
Checklist
composer fix-style