Add support for enum default arguments using enum cases #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8vjork
changed the title
|
Can you please add a test too? |
|
@mfn Will try, don't know if there are tests for these default values, I was looking around and didn't found something I can adapt to this, or do you think I should add a new folder instead? |
|
Ok I reply myself, I think this should go in a new folder so we can mark it as PHP 8+ only as these enums won't work on PHP 7 tests |
|
Ok tests added and passing on PHP 8.2, also added same way it was done for Laravel 9 only tests (a condition to check if PHP 8.1+ is running otherwise markAsSkipped the test) |
barryvdh
reviewed
Feb 7, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| - name: Setup PHP | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: 8.0 | |||
| php-version: 8.1 | |||
There was a problem hiding this comment.
Otherwise the UnitEnum does not exist
There was a problem hiding this comment.
Probably always should run on the latest stable (would be 8.2)
barryvdh
approved these changes
Feb 7, 2024
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* add case when default value is of type enum * Update CHANGELOG.md * add tests for enum arguments default values * ignore psalm issue (built-in `\UnitEnum` class does not exists in PHP7) * Update run-static-analysis.yml to use PHP8.1 --------- Co-authored-by: Barry vd. Heuvel <[email protected]> Co-authored-by: Barry vd. Heuvel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1463
Type of change
Checklist
composer fix-style