Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pivot class property #1518

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Add pivot class property #1518

merged 5 commits into from
Mar 11, 2024

Conversation

d3v2a
Copy link
Contributor

@d3v2a d3v2a commented Feb 16, 2024 •
edited
Loading

Summary

This PR add pivot property when using a pivot model on BelongsToMany relation

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md (not necessary)
  • Code style has been fixed via composer fix-style

@d3v2a d3v2a mentioned this pull request Feb 16, 2024
Closed
9 tasks
mfn
mfn requested changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank, can you add a test showing this feature please?

@barryvdh
Copy link
Owner

Hmm two tests are failing

mfn
mfn approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d3v2a
Copy link
Contributor Author

d3v2a commented Mar 9, 2024

@barryvdh Is there anything more to do?

@d3v2a d3v2a force-pushed the add_pivot_class_property branch from 2576db6 to d98b9df Compare March 10, 2024 11:42
mfn
mfn approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barryvdh Is there anything more to do?

Nah it's good, we just need "humans with time" to do it :)

@barryvdh barryvdh merged commit ac7e186 into barryvdh:master Mar 11, 2024
26 checks passed
@d3v2a d3v2a deleted the add_pivot_class_property branch March 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3v2a @barryvdh @mfn