Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --smart-reset completely #1525

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Remove --smart-reset completely #1525

merged 2 commits into from
Feb 19, 2024

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Feb 19, 2024

Summary

See #1523 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Feb 19, 2024
@mfn mfn force-pushed the mfn-remove-smart-reset branch from 524ec04 to 6d653fe Compare February 19, 2024 12:54
@mfn mfn requested a review from barryvdh February 19, 2024 12:56
@barryvdh barryvdh merged commit 49ac75d into barryvdh:master Feb 19, 2024
26 checks passed
@mfn mfn deleted the mfn-remove-smart-reset branch February 19, 2024 13:18
@KentarouTakeda KentarouTakeda mentioned this pull request Oct 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryvdh barryvdh barryvdh approved these changes

Assignees

@mfn mfn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfn @barryvdh