Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat guess macro types #1648

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Feat guess macro types #1648

merged 2 commits into from
Jan 1, 2025

Conversation

barryvdh
Copy link
Owner

@barryvdh barryvdh commented Jan 1, 2025

Summary

When a Macro is set for eg. the Client class, we cannot always know the return type. For ClientFactory, we assume the macro is a PendingRequest, even without typehints.

Fixes #1565

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh merged commit beda399 into master Jan 1, 2025
17 checks passed
@barryvdh barryvdh mentioned this pull request Jan 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro on HttpClient does not return correct Return statement
1 participant
@barryvdh