Fix non-facade classes will result in no autocomplete

[netpok]

Currently non-facade classes are resulting non functioning autocomplete. The reason of this that an empty class will be defined in the ide helper class, which will be used for the auto-completion. This pull request prevents this behavior by only handling facades in the namespaced part of the helper file.

Unlike #802 this pull request will keep the alias registration.

Fixes #784

[mfn]

https://github.com/barryvdh/laravel-ide-helper/pull/841/files?w=1 :-)

[netpok]

Hoops, I accidentally removed the spaces (not that they should be there).

[mfn]

Seems to me this is the same as #802 but with less "noise"?

[netpok]

Sorry for the late reply, the problem with #802 is that it will remove the Arr and Str classes from the

namespace{
    // ...
}

section so the \Arr and \Str calls will lose autocomplete.

Also the import

use Illuminate\Support\Facades;

should be

use Illuminate\Support\Facades\Facade;

because currently it filters out all the facades. I think this was some newer change because originally it worked for me (I think).

---

This version does not have the mentioned issues. Also I rebased my pull request to the latest master.

[nalatreb]

I think you should update your branch, because there are changes in this method: getAliasesByExtendsNamespace

[netpok]

Ok. I rebased it to current master.

[mfn]

Why is this removed?

[netpok]

It was originally filtered out because it's not a facade so it doesn't need to be there but all non facade classes are filtered out already.

I found the original issue: #451, it was basically the same as this but then it was only limited to one class (Model) instead of three (Model, Arr, Str).

[mfn]

Ah, nice, thank you 👍

[mfn]

Generally LGTM

There's one thing I'm not sure: AFAIK people sometimes expect non-Facades also to show up here, which would have happened before.

Also I hope at some day we can have some tests for this, but I see that this isn't easy here…

[netpok]

Basically you don't want the non Facade classes show up there as they would be empty and break the aliased classes. They still show up in the alias section, so Illuminate\Support\Arr will not be here but \Arr extends Illuminate\Support\Arr will be here.

[mfn]

Thank you for your clarification, makes sense to me!

[netpok]

Does this PR needs any more attention from me or is it good for now?

[mfn]

Good question, I think we wait for approval from @barryvdh

[netpok]

@barryvdh Any blocking reason here I should resolve?

[KentarouTakeda]

@barryvdh @mfn
Do we have any update?
With this nice fix, It will prevent phpstan>=1.7 from reporting many errors to empty helper class.

[mfn]

Still has my 👍🏼 !

[snmatsui]

ping