Add support for custom date class via Date::use() #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 5.8 introduced a feature to support a custom date class via `Date::use()`, see laravel/framework#25320 When e.g. using `Date::use(CarbonImmutable)` in a project, it means all date casts are not returning `\Illuminate\Support\Carbon` anymore but `\Carbon\CarbonImmutable`, which means all the generated type hints for dates are now wrong. This change tries to be still backwards compatible with Laravel < 5.8 which do not have the Date facade.
|
Thanks |
This was referenced Jan 1, 2020
|
This unfortunately only is for the date type model properties. This does not make functions like |
Indeed, this PR is only for the models. I think you're referring to the Facade, right? I don't use them so 🤷♀️ Since the projects I needed for made a final decision to move to immutable, we use |
|
I know a benefit to the facade is that it lets you easily swap out what the current time is considered to be. I don't expect to you to fix this by the way. I rather just wanted to make sure people are aware of this fact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5.8 introduced a feature to support a custom date class via
Date::use(), see laravel/framework#25320When e.g. using
Date::use(CarbonImmutable)in a project, it meansall date casts are not returning
\Illuminate\Support\Carbonanymorebut
\Carbon\CarbonImmutable, which means all the generated type hintsfor dates are now wrong.
This change tries to be still backwards compatible with Laravel < 5.8
which do not have the Date facade.