Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that model_locations/dir now supports glob #925

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Apr 22, 2020

Feature was added with #921

@@ -89,6 +89,9 @@
| Define in which directories the ide-helper:models command should look
| for models.
|
| glob patterns are supported to easier reach models in sub-directories,
| e.g. `app/Services/* /Models` (without the space)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why the space?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah well :) because otherwise it would end the phpdoc 💥

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I tried (maybe too hard) to give a useful example

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe good point.

@mfn mfn marked this pull request as ready for review April 22, 2020 19:18
@barryvdh barryvdh merged commit b7197ae into barryvdh:master Apr 22, 2020
@mfn mfn deleted the mp-glob-doc branch April 22, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants