Merge Feuerlabs/exometer_core 1.2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slot_slide version of histograms picks percentile items from the skew heap (if configured). In this case, it picks from a reversed list, since the heap keeps only the largest values. A slight difference in percent calculations could cause an off-by-one error when comparing the items picked by the exometer_slide and the exometer_slot_slide histograms.
update OTP target platforms for travis
Pick percentile items consistently in histograms
Adjust reporter timers against drift
Switched the order of arguments in the callback definition
Avoid crashing when calling resubscribe() with a non-integer interval
Bump folsom dependency to 0.8.2
Add checks for alias maps + test suite
verify number type for histogram updates
…the standard Erlang mode in Emacs
Reformat according to Erlang mode in Emacs
The setup application is required by exometer_core when it starts so add it to the list of applications to ensure it is included in release builds. This avoids applications that include exometer_core as a dependency from having to explicitly list the setup application in a release configuration.
Fix #12 Metrics find and select are not retried when subscribbed to statically
Use application:ensure_all_started to start all required applications for exometer_core when doing test case initialization in the common_test suites. Also stop each started application during test case cleanup.
The main reason for doing this is to simplify unit testing, but also interactive testing with reporters. Rather than having repeating output, or (in unit tests) having to wait for some time before output is generated, a report batch can now be triggered on demand.
Add 'manual' type to named reporting intervals
add value16, value32, value64 datapoints to counter
- Delete of failed probe didn't work - Restart parameterization support in exometer_probe (see edoc) - Disabled probes (e.g. histograms) are now terminated - When re-enabled, probes are re-instantitated - If new entries include aliases, these are checked in advance - Support for deleting all cached datapoints for a given entry - Fix exometer:start(), which had become broken - Make sure eunit tests succeed - Add ct.config with lager log config - Fix breakage in CT test case init and cleanup - Add test suite for supervision functionality
Added exometer_report_logger and test suite
Conflicts: src/exometer_util.erl test/exometer_SUITE.erl
The slot_histogram test tends to fail occasionally, like depending on the fact that the update sequence is slightly timing-sensitive (the slot_slide histograms use 10 ms time slots). This change runs the test several times, and considers it a success if the majority of results match the expectation.
cancel timer for triggered intervals
Repaired and extended probe supervision
Make slot_histogram test more robust
fix bugs in logger flow control
add OTP 17.4 to CI queue
Make more use of the majority() function in the test suites Use 5 attempts as the default when using majority/2 Increase timeout in the reporting test
e.g. `CT_MAJORITY_COUNT=10 make`
More timing-robust test execution
|
As a reference, this is the CI build for the merged version: https://travis-ci.org/Feuerlabs/exometer_core/builds/59351228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meck and folsom deps adjusted to basho requirements.