This repository was archived by the owner on Jan 8, 2019. It is now read-only.
add attributes support to haproxy #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cbaenziger
reviewed
Sep 14, 2018
|
|
||
| defaults | ||
| log global | ||
| maxconn 8000 | ||
| source <%="#{node[:bcpc][:management][:vip]}"%> | ||
| source <%= @local_ip %> |
There was a problem hiding this comment.
Yea! This allows us to properly health-check MySQL again?
|
@leochen4891 is this good to merge? |
|
Tested. |
vt0r
reviewed
Sep 20, 2018
| default_backend backend_oozie | ||
|
|
||
| backend backend_oozie | ||
| <% @ha_services.each do |service| -%> |
There was a problem hiding this comment.
This logic should probably move back out to the recipe, if possible. JK LOL
| <% @oozie_servers.each do |server| -%> | ||
| <%= "server #{float_host(server[:fqdn])} #{server['bcpc']['floating']['ip']}:11000 check" %> | ||
| <% end -%> | ||
| <% if !service['http_check_url'].nil? and !service['http_check_expect_str'].nil? -%> |
vt0r
approved these changes
Sep 20, 2018
This was referenced Sep 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added attributes to remove some dependency from bcpc to bcpc-hadoop, and makes it easier to support HA services.
Also, included existing oozie ha to above mechanism.