-
Notifications
You must be signed in to change notification settings - Fork 66
Allow MySQL to be served by HAProxy again #1275
Conversation
f4e8e77
to
51902c0
Compare
…start error' on ubuntu 14.04
51902c0
to
985ea9c
Compare
It is definitely not correct to have mysql listening on management ip my.cnf while haproxy is configured using floating ip. |
One of the easiest ways to see what the structure was before #1269 is to run
You can see I have most all cluster services listening on the floating IP or floating VIP; while cluster-internal services or management services which tenants do not need to connect to are listening on the management IP. (Particularly, MySQL is listening on the management VIP.) The design is supposed to be pretty simple that management services not intended for tenant usage end up on the management interface while the floating interface is our "service" interface. (Renaming it this way in our code and getting rid of the deprecated storage interface would be helpful to make this more obvious I now see.) |
I can confirm I was able to build master with this change. |
cookbooks/bcpc/attributes/apache2.rb
Outdated
|
||
# links to services (an hash of hashes with structure: | ||
# <name>=>{'desc':<desc> and 'url':<url>} to be listed) | ||
bach_web['links'] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the default value.
I think the comment is correct, and it should be {}
rather than [] (reference here)
Although service_ports
and files
are set by hdfs and hbase attribute file, it might be safer to set the default value here as well, adding
bach_web['service_ports'] = {}
bach_web['files'] = {}
Thanks for the explanation. |
fedfa67
to
7b48192
Compare
@leochen4891 Please see if my descriptions match what you were thinking? |
Thanks for the update. LGTM |
This should fix the issues mentioned in #1274 . Running test over night to ensure a VM cluster builds.