Support adding React Native promise rejection stacktraces #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Feb 3, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/DeliveryDelegate.java
Outdated
Show resolved
Hide resolved
Android notifier sizes
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ports the changes from #1001 and #1006 which allows serializing the React Native promise rejection stacktrace in the Error API payload. This was originally implemented on this branch: https://github.com/bugsnag/bugsnag-android/tree/integration/capture-ndk-stack-traces-for-anrs
Changeset
typefield toStackframewhich allows overriding the default type of an errorBugsnag-Stacktrace-TypesheaderTesting
Relied on existing test coverage that was added in the original PRs. Additionally tested with the JS changes on this branch: bugsnag/bugsnag-js#1279
Note: the branch is failing due to a known flake which has been addressed here: #1108