-
Notifications
You must be signed in to change notification settings - Fork 208
Support setting error type on individual stack frames #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting error type on individual stack frames #1001
Conversation
0156ea8
to
ac0b1d0
Compare
Android notifier sizes
Generated by 🚫 Danger |
ac0b1d0
to
7c426f5
Compare
7c426f5
to
36a5339
Compare
ab3a2a2
to
9ba924a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API spec, and the intent of the change, is for the field says that the frame type should be set where it doesn't match the error type. I don't think we should be setting the type for all NDK frames - only when it's been set explicitly either in a callback or by one of the new features.
9ba924a
to
3639e0a
Compare
3639e0a
to
ff5688d
Compare
ff5688d
to
47e97d1
Compare
Updated changeset so that the This should be ready for another round of review, pending the results of CI. |
977187c
to
47cc1b0
Compare
47cc1b0
to
4e13c1d
Compare
bugsnag-android-core/src/main/java/com/bugsnag/android/EventStore.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/NativeInterface.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventPayload.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventStore.java
Outdated
Show resolved
Hide resolved
90eb77b
to
ec82bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner 👍 I've made some suggestions from the point-of-view of someone reading this for the first time, to make the abstraction cleaner.
bugsnag-android-core/src/main/java/com/bugsnag/android/EventFilenameInfo.kt
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventPayload.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventStore.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventFilenameInfo.kt
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/EventStore.java
Outdated
Show resolved
Hide resolved
Assert that exception stacktrace is equal to thread stacktrace
Goal
Supports setting the error type on individual stackframes by setting the
Bugsnag-Stacktrace-Types
header. This allows the pipeline to distinguish events and process them accordingly. Supported values areandroid, c, reactnativejs
. These are set as a comma delimited string.Changeset
errorApiHeaders()
to setBugsnag-Stacktrace-Types
header if the value has been setBugsnag-Stacktrace-Types
from the event (by checking all the types set on every stackframe) and from the file (by checking encoded info in the filename)EventStore
to encode the error types in the event fileAnrPlugin
now updates thethread.0.stacktrace
when capturing an error - previously onlyerrors.0.stacktrace
was updated, which lead to a disparity in information on the dashboardEventFilenameInfo
file which holds classes/functions responsible for encoding/decoding event information into anEvent
Testing
type
is serializedtype
field