-
Notifications
You must be signed in to change notification settings - Fork 208
5393 native anr scenarios #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fractalwrench
merged 2 commits into
integration/capture-ndk-stack-traces-for-anrs
from
5393-native-anr-scenarios
Nov 20, 2020
Merged
5393 native anr scenarios #997
fractalwrench
merged 2 commits into
integration/capture-ndk-stack-traces-for-anrs
from
5393-native-anr-scenarios
Nov 20, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c19964f
to
344878c
Compare
Android notifier sizes
Generated by 🚫 Danger |
090b65e
to
e4561d0
Compare
e4561d0
to
ac82716
Compare
Rebased branch to resolve conflicts - this adds the minimal test fixture which means it'll be possible to run scenarios against an app that doesn't have bugsnag's NDK plugin installed. |
...ava/com/bugsnag/android/mazerunner/scenarios/CXXAnrWithNdk_OutsideReleaseStagesScenario.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/bugsnag/android/mazerunner/scenarios/CXXAnrWithNdk_NdkDisabledScenario.java
Outdated
Show resolved
Hide resolved
...-scenarios/src/main/java/com/bugsnag/android/mazerunner/scenarios/CXXAnrWithNdkScenario.java
Outdated
Show resolved
Hide resolved
...ner/cxx-scenarios/src/main/java/com/bugsnag/android/mazerunner/scenarios/CXXAnrScenario.java
Outdated
Show resolved
Hide resolved
7ec8743
to
5b2c609
Compare
5b2c609
to
ae315d1
Compare
8753f12
to
958526a
Compare
Updated the changeset with the following to enable ANR scenarios:
Further assertions about the stackframe's type will be added in a separate PR after #1001 has been merged. |
...arios/src/main/java/com/bugsnag/android/mazerunner/scenarios/JvmAnrMinimalFixtureScenario.kt
Show resolved
Hide resolved
bugsnag-plugin-android-anr/src/main/java/com/bugsnag/android/AnrPlugin.kt
Outdated
Show resolved
Hide resolved
958526a
to
fd4cece
Compare
tomlongridge
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We have ANR scenarios, but none that are caused from native code
Design
Add additional scenarios that are caused by native code.
Testing
These are e2e tests.