Skip to content

5393 native anr scenarios #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kstenerud
Copy link
Contributor

Goal

We have ANR scenarios, but none that are caused from native code

Design

Add additional scenarios that are caused by native code.

Testing

These are e2e tests.

@kstenerud kstenerud changed the base branch from master to integration/capture-ndk-stack-traces-for-anrs November 12, 2020 12:50
@kstenerud kstenerud force-pushed the 5393-native-anr-scenarios branch from c19964f to 344878c Compare November 12, 2020 15:56
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 12, 2020

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1444.59 1364.49
arm64_v8a 373.35 291.42
armeabi 348.76 266.85
armeabi_v7a 332.39 250.47
x86 410.2 328.28
x86_64 393.82 311.9

Generated by 🚫 Danger

@kstenerud kstenerud marked this pull request as ready for review November 13, 2020 09:43
@kstenerud kstenerud force-pushed the 5393-native-anr-scenarios branch 3 times, most recently from 090b65e to e4561d0 Compare November 13, 2020 15:23
@fractalwrench fractalwrench force-pushed the 5393-native-anr-scenarios branch from e4561d0 to ac82716 Compare November 18, 2020 10:07
@fractalwrench
Copy link
Contributor

Rebased branch to resolve conflicts - this adds the minimal test fixture which means it'll be possible to run scenarios against an app that doesn't have bugsnag's NDK plugin installed.

@kstenerud kstenerud force-pushed the 5393-native-anr-scenarios branch 4 times, most recently from 7ec8743 to 5b2c609 Compare November 19, 2020 14:16
@kstenerud kstenerud force-pushed the 5393-native-anr-scenarios branch from 5b2c609 to ae315d1 Compare November 19, 2020 15:26
@fractalwrench fractalwrench force-pushed the 5393-native-anr-scenarios branch 9 times, most recently from 8753f12 to 958526a Compare November 20, 2020 13:22
@fractalwrench
Copy link
Contributor

fractalwrench commented Nov 20, 2020

Updated the changeset with the following to enable ANR scenarios:

  • Moved scenarios to features/full and features/minimal depending on which feature they run against, as suggested by @twometresteve
  • Added CXXAnrScenario/CXXAnrNdkDisabledScenario which trigger native ANRs
  • Renamed existing ANR scenario classes and converted them to trigger purely JVM ANRs
  • Split detect_anr.feature into three separate features:
    • One for JVM scenarios
    • One for CXX scenarios
    • One for an ANR in a minimal test fixture

Further assertions about the stackframe's type will be added in a separate PR after #1001 has been merged.

@fractalwrench fractalwrench merged commit a22f246 into integration/capture-ndk-stack-traces-for-anrs Nov 20, 2020
@fractalwrench fractalwrench deleted the 5393-native-anr-scenarios branch November 20, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants