[FC] Allow a portion of machines to skip saving snapshots #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only applies to action executions which were already created from a snapshot. My hypothesis is that saving an updated snapshot doesn't provide future executions any benefit in these cases. I choose to use the hostname to split the experiment, because I want every executor on a machine to write less to the filecache if it's in the experiment.
vanja-p
changed the title
vanja-p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only applies to action executions which were already created from a snapshot. My hypothesis is that saving an updated snapshot doesn't provide future executions any benefit in these cases.
I choose to use the hostname to split the experiment, because I want every executor on a machine to write less to the filecache if it's in the experiment.
TODO: Still need to work on tests.