Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the executor hostname in clickhouse #8656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vanja-p
Copy link
Contributor

@vanja-p vanja-p commented Mar 14, 2025

This will allow evaluating experiments where we want a feature to be on/off on a whole machine.

Initially, I want to evaluate #8655.

This will allow evaluating experiments where we want a feature to be on/off on a whole machine.
@tylerwilliams
Copy link
Member

Any idea how this will affect storage (since it's a potentially long string)?

@vanja-p
Copy link
Contributor Author

vanja-p commented Mar 14, 2025

Any idea how this will affect storage (since it's a potentially long string)?

invocation_uuid takes about 1%, and it's probably longer and harder to compress then hostname, so I think less than 1% of additional storage.

@maggie-lou
Copy link
Contributor

If we want to avoid doing this for now, we could test this on baremetal nodes and hard code which ones are assigned to the experiment because they have static names

@vanja-p
Copy link
Contributor Author

vanja-p commented Mar 15, 2025

I would like to some way to compare execution statistics (exec and pause time for firecracker actions at least) between machines in and out of the experiment, so as long as I can do that, it works for me. Can we isolate individual baremetal hosts when looking at prometheus metrics?

I think it would be good for us to have a general way of doing this across cloud and bare metal, but maybe it's not so important.

hard code which ones are assigned to the experiment because they have static names

How would we do this? In the Go code, or creating a separate deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants