Don't fire events if you're inside a textfield/input in a shadow DOM

[robinsk]

Events occuring in a shadow DOM are retargeted to look like they come from the host element. Use event.path rather than event.target to get the actual element in which the event occured.

This pull request fixes #245.

[ccampbell]

For the typeof check and constructor check can you please update to use ===

[ccampbell]

Also I just checked and the second test now no longer runs via phantom js

TypeError: 'undefined' is not a function (evaluating 'shadow.createShadowRoot()')

Is this just a matter of updating mocha/phantomjs or is this a known thing?

[robinsk]

That's a bit weird. I was sure I had that test running fine in both browser and phantom.

I know the polymer guys use mocha for testing, so I guess it'll work if just the test libs are upgraded. I'll look into it.

[vitorgalvao]

What currently is preventing this from being fixed?

[kleinfreund]

It would be amazing if this could be either merged or the underlying issue fixed.

I tried monkey-patching mousetrap.js by adding the following just before the final return statement in Mousetrap.prototype.stopCallback:

// Events originating from a shadow DOM are re-targetted; thus, `e.target` is not always
// the initial event source. If the first element in the event’s composed path is not
// the target, it has a different initial event source than `element`.
if ('composedPath' in e && typeof e.composedPath === 'function') {
    var initialEventTarget = e.composedPath()[0];
    if (initialEventTarget !== e.target) {
        element = initialEventTarget;
    }
}

This seems to work. Should I submit a pull request?

[kleinfreund]

Is this just a matter of updating mocha/phantomjs or is this a known thing?

@ccampbell I’m trying to write a test for my solution posted above and I get same error:

TypeError: 'undefined' is not a function (evaluating 'shadowHost.attachShadow({ mode: 'open' })')

Mocha version 1.9.0 is used by these tests. That version is very outdated and doesn’t know about Element.prototype.attachShadow (or the createShadowRoot() method from above). My test is passing when opening the tests/mousetrap.html file.

[kleinfreund]

This issue was addressed in #445 and can be closed.