Shadow DOM: Stop callbacks from inside an open shadow tree

[kleinfreund]

This pull request:

• fixes Stop events occuring in input fields when using a shadow DOM #245.
• supersedes Don't fire events if you're inside a textfield/input in a shadow DOM #254.
• adds tests for open and closed shadow trees.
• adds a sixth options parameter to KeyEvent.simulate. This was required to re-target the event target with closed shadow trees. The related code contains further explanation.

Important note: The tests pass when opening tests/mousetrap.html in a browser, but not when running npm test. This is due to the test environment not understanding Element.attachShadow; hence, it is throwing on the lines with the call to attachShadow in the test file. I’m not quite sure how to make these tests work with mocha.

[kleinfreund]

@ccampbell Are you interested in continueing with this or should it just be closed?

[ccampbell]

Hi @kleinfreund,

I am not opposed to this change. The problem is more that I don’t have time to actively maintain this project.

The truth is I don’t have a lot of familiarity with Shadow DOM, and I don’t like the idea of breaking the tests.

If you can figure out a way to get the tests to pass then I’d be happy to merge this.

[kleinfreund]

@ccampbell I understand.

I find it very hard to work with the current test suite. I tried adding the shadydom polyfill to the test file. This makes the new tests pass but breaks others (only in the 'wrapping a specific element' category). I have no idea why because they’re unrelated.

The test suite itself isn’t of much help as the only error reporting I get is this:

  1) Mouestrap.addKeycodes
       should properly recognize non-default mapping:
     Uncaught 

I don’t know what’s "Uncaught" or where to start looking. I don’t know how to continue with this. :/