Add support for HA proxy protocol [MAB-25933] #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miharugelj
changed the title
|
cc @celtra/devops |
JureMalovrh
reviewed
Nov 23, 2022
finagle-netty4/src/main/scala/com/twitter/finagle/netty4/haproxy/HAProxyProtocolHandler.scala
Show resolved
Hide resolved
finagle-netty4/src/main/scala/com/twitter/finagle/netty4/haproxy/HAProxyProtocolHandler.scala
Show resolved
Hide resolved
finagle-netty4/src/main/scala/com/twitter/finagle/netty4/haproxy/HAProxyProtocolDetector.scala
Show resolved
Hide resolved
|
@JureMalovrh Thanks for CR, comments and "nice words". I think I addressed your comments, so I am kindly ask you for a second look. |
JureMalovrh
approved these changes
Nov 25, 2022
miharugelj
force-pushed
the
haproxy-protocol
branch
from
36a11ac to
109070b
Compare
a-skuba
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add local build instructions * Init proxy protocol handler * Set HA proxy info in channel context * Expose client source addr and port in request * Cleanup * Server HA proxy protocol on/off * Fix server ha proxy protocol initialization * HA proxy handler test * Avoid resolving host null to loopback address * Add HA detector and handler tests * Additional assertions * Add HA end-to-end test * init HA proxy protocol * Init HAE2E test * E2E test - check server response * Cleanup * Instructions for running tests locally * Additional comment * Add server configuration validation
miharugelj
added a commit
that referenced
this pull request
Sep 21, 2023
This reverts commit 83405cf.
miharugelj
added a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://celtra.atlassian.net/browse/MAB-25933