-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Maven packages [DEVOPS-1295] #5
Conversation
@miharugelj one test is failing: https://github.com/celtra/finagle/actions/runs/6233342981/job/16918402750?pr=5 Is this the issue from the upstream repo or did we break something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test that this really works? For example you can comment out that release job is only triggered on tags, so that it get's trigger on push.
Almost impossible that we broke anything in this PR related to app code. |
@miharugelj fyi you will need to allow GHA access to |
@dejanceltra You are right. Thanks! Release test already failed with |
@dejanceltra Looks like release job works.
|
@miharugelj Uncomment |
@dejanceltra Sounds like it is is working
|
https://celtra.atlassian.net/browse/DEVOPS-1295