Replace usage of TransactionTestCase
#1183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
swatinem/no-trxtest
branch
from
4be8678 to
8781c63
Compare
🚨 Sentry detected 8 potential issues in your recent changes 🚨
Lower risk findings
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 95.87% 95.86% -0.01%
==========================================
Files 493 493
Lines 16880 16871 -9
==========================================
- Hits 16183 16174 -9
Misses 697 697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ajay-sentry
reviewed
Mar 12, 2025
core/commands/pull/interactors/tests/test_fetch_pull_request.py
Outdated
Show resolved
Hide resolved
The `TransactionTestCase` is documented to be a bit slower than the normal one, and someone mentioned recently that this might be the reason why API tests are taking so long. So lets try changing that, and see whether the testsuite still works :-)
Swatinem
force-pushed
the
swatinem/no-trxtest
branch
from
fc66113 to
8a3d079
Compare
ajay-sentry
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TransactionTestCaseis documented to be a bit slower than the normal one, and someone mentioned recently that this might be the reason why API tests are taking so long.So lets try changing that, and see whether the testsuite still works :-)