Add unique ids for each block #1333

christoph-kluge · 2020-09-25T22:44:47Z

I'm adressing #873 with this PR.

Tested Features:

Existing data: If your previous block does not have an "id" property, it will create a new unique id
Existing data: If your previous block does have an "id" property, it will keep the existing unique id
Existing data: If a block gets changed the "id" property stays the same
Insert New Block: It will create a new unique id
Copy & Paste blocks: It will create a new unique ids per copied block
Move Blocks (Up/Down): It will keep the existing unique id

Important Note:

If you "transform/transition" an existing block to another block it will receive a NEW unique id

dsaralaya · 2020-10-01T16:16:56Z

I need this feature pls merge

christoph-kluge · 2020-10-16T16:31:36Z

Updated this PR and fixed conflicts.

Is there any update about unique block ids? How do you want to proceed with this issue/feature?

sis-dk · 2020-10-19T18:34:54Z

Does this handle creating a new id when copying a block and pasting it as a new block? Initialise empty editor, type a para block, CMD+A (selects all the blocks. In our case the para block), CMD+V. Would the newly pasted block have a new id?

christoph-kluge · 2020-10-19T19:12:09Z

@sis-dk thanks for spotting the copy & paste issue. I have adressed this in my latest commit

mqtik · 2020-10-31T02:09:22Z

Why don't use shortid for id generation?
It's what I'm about to use in a module I'm working on (native side), but this one uses shortid to generate ID's.

Just want to keep consistent.

christoph-kluge · 2020-10-31T11:24:21Z

I have used this feature on a custom build since 2.15.2 with UUIDs. Now I wanted to update for latest >2.18+ version and simply ported this feature with UUIDs. I think we could also add some custom configuration/callback to generate the IDs in a different way. Since One editor will not have quadrillions of entries I could imageine that shortids are pretty valid too 👍

Maybe the maintainers (@neSpecc, @khaydarov, @gohabereg) could give a statement about this. I'm fine to add some custom configuration/callback to support custom-ids instead of hardcoded uuids.

hata6502 · 2020-11-21T07:31:24Z

src/components/modules/blockSelection.ts

+    const savedData = await Promise.all(
+      this.selectedBlocks.map((block) => {
+        block.id = _.generateUuidv4();
+        block.save();


Suggested change

block.save();

return block.save();

const savedData is void[] currently.

So copy paste functions via this.Editor.Paste.MIME_TYPE is not worked.

hata6502 · 2020-11-21T07:39:22Z

src/components/modules/blockSelection.ts

-    const savedData = await Promise.all(this.selectedBlocks.map((block) => block.save()));
+    const savedData = await Promise.all(
+      this.selectedBlocks.map((block) => {
+        block.id = _.generateUuidv4();


Suggested change

block.id = _.generateUuidv4();

const savedData = await Promise.all(this.selectedBlocks.map(async (block) => ({

...await block.save(),

id: _.generateUuidv4()

})));

block.id = _.generateUuidv4(); may be unsafe because of object mutation.

hata6502 · 2020-11-21T07:46:00Z

src/components/modules/blockSelection.ts

+        block.id = _.generateUuidv4();
+        block.save();
+      })
+    );


This file changes may be not needed because IDs should be regenerated in paste function.

hata6502 · 2020-11-21T07:47:58Z

src/components/modules/paste.ts

@@ -772,6 +772,7 @@ export default class Paste extends Module {
      }

      BlockManager.insert({
+        id,


Suggested change

id,

The IDs of pasted data via this.Editor.Paste.MIME_TYPE should be regenerated in paste function.
When copy as this.Editor.Paste.MIME_TYPE one time and pasted multiple times, The IDs are duplicated.

hata6502 · 2020-11-21T07:58:32Z

types/data-formats/output-data.d.ts

+  /**
+   * Unique Id of the block
+   */
+  id: string;


Suggested change

id: string;

id?: string;

By allowing undefined value, This PR become UNBREAKING Change.

hata6502 · 2020-11-21T08:01:58Z

src/components/modules/renderer.ts

@@ -63,12 +65,14 @@ export default class Renderer extends Module {
   */
  public async insertBlock(item: OutputBlockData): Promise<void> {
    const { Tools, BlockManager } = this.Editor;
+    const id = item.id || _.generateUuidv4();


Suggested change

const id = item.id || _.generateUuidv4();

const id = item.id;

When const id is undefined, a new ID is generated in BlockManager.insert().

ChasLui · 2020-12-16T10:50:47Z

I need this feature pls merge @christoph-kluge 🙏

neSpecc · 2021-09-13T16:58:34Z

Resolved by #1667

christoph-kluge requested review from gohabereg, khaydarov and neSpecc as code owners September 25, 2020 22:44

christoph-kluge changed the title ~~Add unique ids on next~~ Add unique ids for each block Sep 25, 2020

christoph-kluge mentioned this pull request Sep 25, 2020

Unique id for each block #873

Closed

hata6502 mentioned this pull request Sep 30, 2020

How to add ID for per block in OutputBlockData #1331

Closed

dsaralaya approved these changes Oct 2, 2020

View reviewed changes

khaydarov changed the base branch from next to next-rebased October 14, 2020 09:02

khaydarov changed the base branch from next-rebased to master October 14, 2020 11:59

christoph-kluge added 6 commits October 16, 2020 18:19

Add unique id for each block

3c727ce

Added missing id's from block data after merge/conflict resolution

c2820fb

Removed logging

97686cf

Fixed yarn lint warnings

b377162

Added new build of editor.js

66ab7ed

Added "id" to one existing block for validation reasons

31f120d

christoph-kluge force-pushed the add-unique-ids-on-next branch from d38c047 to 31f120d Compare October 16, 2020 16:25

Fixed import statement for generateUuidv4

4a21037

christoph-kluge changed the base branch from master to next October 16, 2020 16:28

Create new block id when we copy/paste existing blocks

944a339

vujicP mentioned this pull request Nov 15, 2020

Adding custom variable to block #1395

Closed

hata6502 suggested changes Nov 21, 2020

View reviewed changes

ChasLui mentioned this pull request Dec 28, 2020

replace block by id #1474

Open

cobbcheng mentioned this pull request Jan 3, 2021

feat: Add unique ids for each block #1493

Closed

milu2003 mentioned this pull request Feb 17, 2021

I want to set a unique ID for each block data. How should I do it? #1542

Closed

neSpecc closed this Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unique ids for each block #1333

Add unique ids for each block #1333

christoph-kluge commented Sep 25, 2020 •

edited

Loading

dsaralaya commented Oct 1, 2020

christoph-kluge commented Oct 16, 2020

sis-dk commented Oct 19, 2020

christoph-kluge commented Oct 19, 2020

mqtik commented Oct 31, 2020

christoph-kluge commented Oct 31, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

hata6502 Nov 21, 2020

ChasLui commented Dec 16, 2020

neSpecc commented Sep 13, 2021

-        block.id = _.generateUuidv4();
+    const savedData = await Promise.all(this.selectedBlocks.map(async (block) => ({
+      ...await block.save(),
+      id: _.generateUuidv4()
+    })));

	const id = item.id \|\| _.generateUuidv4();
	const id = item.id;

Add unique ids for each block #1333

Add unique ids for each block #1333

Conversation

christoph-kluge commented Sep 25, 2020 • edited Loading

dsaralaya commented Oct 1, 2020

christoph-kluge commented Oct 16, 2020

sis-dk commented Oct 19, 2020

christoph-kluge commented Oct 19, 2020

mqtik commented Oct 31, 2020

christoph-kluge commented Oct 31, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChasLui commented Dec 16, 2020

neSpecc commented Sep 13, 2021

christoph-kluge commented Sep 25, 2020 •

edited

Loading