Unique ids in blocks with nanoid #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Apr 23, 2021
…id, add changelog and some documentation Also improved some documentation along the lines and fixed linting
|
@gohabereg @neSpecc I'll be mostly unavailable to work on this PR for the next couple days, don't hesitate to push more improvements until it's mergeable. If I see more review comments I'll try my best to make the fixes quickly still but I'll try to take the weekend off. |
This was referenced Apr 25, 2021
neSpecc
reviewed
Apr 26, 2021
| it('should preserve passed ids', () => { | ||
| const blocks = [ | ||
| { | ||
| id: nanoid(), |
There was a problem hiding this comment.
We use nanoid (10). What should happen when user pass id not in an our format? We should show error or preserve them? I think, we need to add a test for that case.
There was a problem hiding this comment.
I don't think so. User can use any format for ids on the backend side, even just numbers. We should just preserve everything user passes
neSpecc
approved these changes
Apr 26, 2021
neSpecc
approved these changes
Apr 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested manually a bit and it works nicely with some limitations (Yes the text is gibberish)
What works
What does not