Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: on Edit button, there is + sign overlayed over letter E #5388

Closed
mnalis opened this issue Nov 17, 2023 · 6 comments · Fixed by #5464
Closed

[Bug]: on Edit button, there is + sign overlayed over letter E #5388

mnalis opened this issue Nov 17, 2023 · 6 comments · Fixed by #5464
Labels

Comments

@mnalis
Copy link
Contributor

mnalis commented Nov 17, 2023

Summary

In Step 1/4: Media Details part of the upload, the EDIT IMAGE button shown at bottom left has + sign overlayed over letter E.

Steps to reproduce

  1. open the app
  2. click on + button and choose gallery
  3. select some picture

Expected behaviour

window that opens should have normal text EDIT IMAGE without any + sign overlayed (or, if there is some extra functionality being offered by that + sign, it should be separate and clickable).

Actual behaviour

EDIT IMAGE is shown with + over letter E, making it unreadable

Device name

Huawei P30Pro

Android version

Android 10 (EMUI 12)

Commons app version

4.2.1 ~14b6c455b (latest f-droid)

Device logs

No response

Screen-shots

Screenshot_20231117_134256_fr free nrw commons

Would you like to work on the issue?

None

@mnalis mnalis added the bug label Nov 17, 2023
@nicolas-raoul
Copy link
Member

Thanks for reporting!
I can reproduce this bug by increasing font size in the Android settings:

Screenshot_20231117-223247.png

@chsaikumar445
Copy link

chsaikumar445 commented Dec 11, 2023

@maskaravivek @nicolas-raoul can you please take a look at my pull request?

ShashwatKedia added a commit to ShashwatKedia/apps-android-commons that referenced this issue Jan 8, 2024
@kanahia1
Copy link
Contributor

Hi @nicolas-raoul , Kindly :-) asking do we really need to work on this issue. Since we are moving + sign in design as discussed on #5404

ShashwatKedia added a commit to ShashwatKedia/apps-android-commons that referenced this issue Jan 15, 2024
@nicolas-raoul
Copy link
Member

@kanahia1 Well you are right that sounds like a better place for the +... @ShashwatKedia sorry for not connecting the dots but I think at the right of the first language is a more intuitive place for the +... would you mind moving it there? That would solve the overlapping issue.

@kanahia1
Copy link
Contributor

@ShashwatKedia We can work together on new design of upload activity 🫂 if you agree

@ShashwatKedia
Copy link
Contributor

@ShashwatKedia We can work together on new design of upload activity 🫂 if you agree

@kanahia1 sure, would love to do that. We can discuss further proceedings through Zulip if you want, I've pinged you there

nicolas-raoul added a commit that referenced this issue Jan 23, 2024
…5464)

* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Made UI changes in UploadMediaDetailAdapter

* Added javadoc

---------

Co-authored-by: Nicolas Raoul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment