Resolved Issue #5388 + button

[ShashwatKedia]

Description (required)
The + button near the Edit Image button was not fully visible and thus could not be used properly.

Fixes #5388

What changes did you make and why?
I reduced the marginEnd property of two buttons and also added a translationZ property to the + button so that it always stays above the Edit Image button. I also removed the marginRight property from the PREVIOUS button, as it was redundant due to the presence of marginEnd property.

Tests performed (required)

Tested betaDebug on OnePlus Nord CE 2 Lite with API level 31.

Screenshots (for UI changes only)

Before :

After:

Recording showing the functionality of the + button after the changes:
https://github.com/commons-app/apps-android-commons/assets/142137555/094e41aa-e1bc-44b0-96a5-f6fcb4ff5b02

[nicolas-raoul]

Do you think anything can be done regarding what I get here?

[ShashwatKedia]

@nicolas-raoul The best solution is to remove the PREVIOUS button from the UploadMediaDetailFragment, as the button is redundant. The PREVIOUS button is not used, as UploadMediaDetailFragment is the first screen in media upload. Also, the PREVIOUS button always stays disabled there. Removing the button will solve the problem of overlapping buttons.

[nicolas-raoul]

In order to fix the unit tests, would you mind rebasing (or pulling) from main? Thanks :-)

The PREVIOUS button is not used, as UploadMediaDetailFragment is the first screen in media upload

Unfortunately we often need to Previous button during multi-uploads. For instance, I often remember more details about Picture 1 when writing down details about Picture 2. To initiate a multi-upload, just choose several pictures.

[nicolas-raoul]

With the latest commit on this branch:

[ShashwatKedia]

In order to fix the unit tests, would you mind rebasing (or pulling) from main? Thanks :-)

My apologies, I missed that, I've done rebasing

Unfortunately we often need to Previous button during multi-uploads. For instance, I often remember more details about Picture 1 when writing down details about Picture 2. To initiate a multi-upload, just choose several pictures.

Yeah I realised that, I'll try to add some other changes to margin/width

Do you think anything can be done regarding what I get here?

With the latest commit on this branch:

Yeah, I haven't changed anything yet, could you tell me which device/emulator (with dimensions if possible) you have used here

[nicolas-raoul]

Thanks for rebasing! :-)

I am using a Pixel 7 Pro (real device) with these dimensions and font size:

[nicolas-raoul]

1080x2340

[ShashwatKedia]

Closing this PR as @kanahia1 and I have discussed the new design for upload activity and will have to make a new PR for that, as it is out of the scope of #5388