Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom selector showing actioned pictures: After entering then leaving fullscreen, scrolls to a different place #5873

Closed
nicolas-raoul opened this issue Oct 19, 2024 · 4 comments · Fixed by #5880
Closed

Custom selector showing actioned pictures: After entering then leaving fullscreen, scrolls to a different place #5873

nicolas-raoul opened this issue Oct 19, 2024 · 4 comments · Fixed by #5880
Assignees
@lzhan0121
Labels
bug custom-image-selector

Comments

@nicolas-raoul
Copy link
Member

With Show actioned pictures enabled.

After entering then leaving fullscreen, I am scrolled to a different place in my roll of pictures:

screen-20241018-223309.mp4
@whe128
Copy link
Contributor

whe128 commented Oct 20, 2024

I have found the reason
1.
image
2.
image

@whe128
Copy link
Contributor

whe128 commented Oct 20, 2024

can you assign this issue to me?

@lzhan0121
Copy link
Contributor

Can you reassign this issue to me? Me and whe128 are in the same team for fix issues.

@whe128
Copy link
Contributor

whe128 commented Oct 20, 2024

there is also another problem,

Can you reassign this issue to me? Me and whe128 are in the same team for fix issues.

That is sure.

@nicolas-raoul nicolas-raoul assigned lzhan0121 and unassigned whe128 Oct 21, 2024
lzhan0121 added a commit to lzhan0121/apps-android-commons that referenced this issue Oct 21, 2024
@lzhan0121
Fix: Prevent RecyclerView from resetting scroll position after return…
4067b79 
…ing from preview (commons-app#5873)

Resolved an issue where RecyclerView would incorrectly scroll to the top after exiting fullscreen preview. Adjusted scroll behavior to maintain position unless actioned images are filtered. Implemented observer logic adjustments to handle dataset updates more efficiently.
@lzhan0121 lzhan0121 mentioned this issue Oct 21, 2024
Merged
nicolas-raoul added a commit that referenced this issue Oct 21, 2024
@lzhan0121 @nicolas-raoul
Fix: Prevent RecyclerView from resetting scroll position after return…
7b0b604 
…ing from preview (#5873) (#5880)

Resolved an issue where RecyclerView would incorrectly scroll to the top after exiting fullscreen preview. Adjusted scroll behavior to maintain position unless actioned images are filtered. Implemented observer logic adjustments to handle dataset updates more efficiently.

Co-authored-by: Nicolas Raoul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzhan0121 lzhan0121

Labels
bug custom-image-selector
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #5873 lzhan0121/apps-android-commons
3 participants
@nicolas-raoul @lzhan0121 @whe128