Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5873 #5880

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix issue #5873 #5880

merged 2 commits into from
Oct 21, 2024

Conversation

lzhan0121
Copy link
Contributor

@lzhan0121 lzhan0121 commented Oct 21, 2024

Resolved an issue where RecyclerView would incorrectly scroll to the top after exiting fullscreen preview. Adjusted scroll behavior to maintain position unless actioned images are filtered. Implemented observer logic adjustments to handle dataset updates more efficiently.

issue.5873.mp4

Closes #5873

lzhan0121 and others added 2 commits October 21, 2024 21:29
…ing from preview (commons-app#5873)

Resolved an issue where RecyclerView would incorrectly scroll to the top after exiting fullscreen preview. Adjusted scroll behavior to maintain position unless actioned images are filtered. Implemented observer logic adjustments to handle dataset updates more efficiently.
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now testing this.
Somehow I still get scrolled up sometimes. And if I try again with the exact same picture in the exact same picture set, no scroll up. Strange.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure mis-scrolls much less than the main branch though.
That's a very positive change. Thanks! :-)

@nicolas-raoul nicolas-raoul merged commit 7b0b604 into commons-app:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants