Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(build): replace webpack with babel standalone #10

Merged
merged 6 commits into from
Feb 24, 2017
Merged

refactor(build): replace webpack with babel standalone #10

merged 6 commits into from
Feb 24, 2017
+4,541 −53

Conversation

axe312ger
Copy link
Contributor

also introduces a es-modules version for treeshaking supporting environments

@axe312ger axe312ger force-pushed the refactor/babel-replaces-webpack branch from 3a43f70 to 1ae11a8 Compare February 21, 2017 16:45
Khaledgarbaya
Khaledgarbaya reviewed Feb 21, 2017
View reviewed changes
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing, can you Update the README, explaining the architecture of the lib and how we can build it

.babelrc Outdated
"presets": [
"es2015"
],
"plugins": ["babel-plugin-rewire"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just specify rewire here if we are going to update to the latest one

@axe312ger axe312ger force-pushed the refactor/babel-replaces-webpack branch from 1ae11a8 to a62bba1 Compare February 21, 2017 17:42
@axe312ger axe312ger mentioned this pull request Feb 22, 2017
Merged
Khaledgarbaya
Khaledgarbaya suggested changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good, It would be nice if you Update the README describing the new structure and how to build it and how to use the library

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling a7ec734 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling ac1383f on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 16ff4a1 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 7b003c2 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ea052f7 on refactor/babel-replaces-webpack into ** on fix-build**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ea052f7 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ea052f7 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 1d41328 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 1d41328 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 1be2483 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe05a31 on refactor/babel-replaces-webpack into ** on fix-build**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe05a31 on refactor/babel-replaces-webpack into ** on fix-build**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe05a31 on refactor/babel-replaces-webpack into ** on fix-build**.

Khaledgarbaya and others added 5 commits February 23, 2017 18:05
@Khaledgarbaya
build(axios): Remove axios vendoring

Verified

This commit was signed with the committer’s verified signature.
jbr Jacob Rothstein
GPG key ID: C38BA18C6CFE15A5
Verified
Learn about vigilant mode
d430b92
@Khaledgarbaya
build(node): Drop support for node < 4.7

Verified

This commit was signed with the committer’s verified signature.
jbr Jacob Rothstein
GPG key ID: C38BA18C6CFE15A5
Verified
Learn about vigilant mode
2517bfc
@Khaledgarbaya
chore(contentful-sdk-core): Minimize bundle size 🎉

Verified

This commit was signed with the committer’s verified signature.
jbr Jacob Rothstein
GPG key ID: C38BA18C6CFE15A5
Verified
Learn about vigilant mode
99afcc5
@Khaledgarbaya
refactor(build): replace webpack with babel standalone

Verified

This commit was signed with the committer’s verified signature.
jbr Jacob Rothstein
GPG key ID: C38BA18C6CFE15A5
Verified
Learn about vigilant mode
a9e941c
@Khaledgarbaya
docs(README): add badges, docs and polyfills
b55da4d
@Khaledgarbaya Khaledgarbaya force-pushed the refactor/babel-replaces-webpack branch from fe05a31 to b55da4d Compare February 23, 2017 17:08
@Khaledgarbaya
Copy link
Contributor

@axe312ger reorganized commit history now, we should be good for tomorrow

@coveralls
Copy link

coveralls commented Feb 23, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 33e433b on refactor/babel-replaces-webpack into ** on fix-build**.

This was referenced Feb 24, 2017
Merged
Closed
Khaledgarbaya
Khaledgarbaya suggested changes Feb 24, 2017
View reviewed changes
package.json
@@ -1,19 +1,22 @@
{
"name": "contentful-sdk-core",
"version": "1.0.0-determined-by-semantic-release",
"version": "3.5.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we can bring it back to 0.0.0-placeholder since we finished the manual release

package.json
"lodash": "^4.17.4",
"qs": "^6.1.0",
"webpack": "^1.14.0"
"qs": "^6.1.0"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add

"publishConfig": {
  "tag": "alpha"
}

so when we merge to master the the auto release will still release under alpha or maybe we can promote to beta

README.md
- stop vendoring axios and remove babel-runtime, along with support for node.js 0.10
Emulate a CI test run:
```
npm run test:ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't test:ci for the actual ci, for emulating maybe we can have test:ci-emulate

README.md

## Pre-requisites

* Make sure you use at least Node 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 4.7

@axe312ger axe312ger merged commit fc8ab0f into fix-build Feb 24, 2017
@axe312ger axe312ger deleted the refactor/babel-replaces-webpack branch February 24, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khaledgarbaya Khaledgarbaya

Assignees

@Khaledgarbaya Khaledgarbaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axe312ger @coveralls @Khaledgarbaya