remove axios vendoring #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
previously requested changes
Feb 24, 2017
package.json
Outdated
| "babel-loader": "^6.2.10", | ||
| "lodash": "^4.17.4", | ||
| "qs": "^6.1.0", | ||
| "webpack": "^1.14.0" |
package.json
Outdated
| "lodash": "^4.2.0", | ||
| "qs": "^6.1.0" | ||
| "axios": "^0.15.3", | ||
| "babel-loader": "^6.2.10", |
There was a problem hiding this comment.
or no, even a duplicate dependency, the loader is in the dev deps already
webpack.config.js
Outdated
| context: path.join(__dirname, 'lib'), | ||
| entry: { | ||
| 'create-backoff': ['./create-backoff.js'], | ||
| 'rate-limit': ['./rate-limit.js'], // why? 👉 https://github.com/webpack/webpack/issues/300 |
There was a problem hiding this comment.
Webpack 2 may fix this. Upgrading is not that hard, should we try?
|
we continue with #10 |
|
okay lets avoid crazy merges and keep the chain simple -> reopening |
|
removed all the spammy coveralls messages |
Khaledgarbaya
commented
Feb 24, 2017
.eslintrc.js
Outdated
| "standard", | ||
| "promise" | ||
| ] | ||
| }; |
There was a problem hiding this comment.
standard 👉🏼 ;
webpack.config.js
Outdated
| @@ -0,0 +1,54 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
didn't we remove webpack, why this is here ?
Khaledgarbaya
force-pushed
the
fix-build
branch
from
e76064f to
8d39150
Compare
Khaledgarbaya
force-pushed
the
fix-build
branch
from
be80410 to
520ad01
Compare
|
ok Rebased master and resolved some conflicts with master |
|
Changes Unknown when pulling 520ad01 on fix-build into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fxing #3
TODO