add GenerateInitContainers function to generator #89
Conversation
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
There was a problem hiding this comment.
preStart is now apply, so we should update it. Its one of the reasons why odo disabled preStart because they dont support it atm
we should also probably update odo code and remove where they call initContainers, err := utils.GetPreStartInitContainers(a.Devfile, containers) since its never executed 🤔
| @@ -50,6 +50,33 @@ func GetExecWorkingDir(dc v1.Command) string { | |||
| return "" | |||
| } | |||
|
|
|||
| // GetApplyComponent returns the component of the exec command | |||
There was a problem hiding this comment.
update desc and a test case?
Signed-off-by: Stephanie <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie [email protected]
What does this PR do?
This PR adopts
GenerateInitContainersand it's supporting functionsgetCommandsFromEventandgetCommandsMapfrom odo, including the unit tests associated with those functionsWhat issues does this PR fix or reference?
devfile/api#181
Is your PR tested? Consider putting some instruction how to test your changes
add unit tests